fix: html entities footer rendering#6966
Merged
vitormattos merged 4 commits intomainfrom Feb 19, 2026
Merged
Conversation
Variables signedBy and validateIn are already escaped by htmlentities() in FooterHandler. Adding |raw filter prevents Twig from escaping again, which was causing HTML entities to appear literally in PDF footers. Fixes #6961 Signed-off-by: Vitor Mattos <[email protected]>
Add DataProvider test with 14 scenarios covering: - European languages (French, Portuguese, Spanish, German) - Greek and Cyrillic alphabets - RTL languages (Arabic, Hebrew) - CJK scripts (Chinese, Japanese, Korean) - Emoji and mixed character sets Validates that accented characters and special Unicode render correctly in PDF footers without HTML entity escaping. Related to #6961 Signed-off-by: Vitor Mattos <[email protected]>
Add explicit comments warning translators not to translate mustache
template variables ({{variableName}}) in signature text strings.
This prevents corruption of template syntax during localization.
Discovered during investigation of #6961 where French translation
had corrupted mustache braces.
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable33 |
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
This was referenced Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.